Rename image from jetty9 to jetty #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meltsufin
force-pushed
the
reversion
branch
2 times, most recently
from
45697b4
to
7fe02fe
Compare
meltsufin
force-pushed
the
reversion
branch
from
7fe02fe
to
e8801f4
Compare
Closed
|
@aslo PTAL |
aslo
reviewed
Sep 26, 2016
| @@ -5,18 +5,18 @@ This repository contains the source for the `gcr.io/google_appengine/jetty` [doc | |||
| The layout of this image is intended to mostly mimic the official [docker-jetty](https://github.com/appropriate/docker-jetty) image and unless otherwise noted, the official [docker-jetty documentation](https://github.com/docker-library/docs/tree/master/jetty) should apply. | |||
|
|
|||
| ## Building the Jetty image | |||
| To build the image you need git, docker and maven installed and to have the openjdk8:8-jre | |||
| To build the image you need git, docker and maven installed and to have the openjdk:8 | |||
| image available in your docker repository: | |||
| ```console | |||
| git clone https://github.com/GoogleCloudPlatform/jetty-runtime.git | |||
There was a problem hiding this comment.
Should also cd jetty-runtime after cloning.
|
LGTM, other than one small nit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53