feat(routeoptimization): New code samples #9367
Conversation
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
product-auto-label
bot
added
the
samples
| <dependency> | ||
| <groupId>com.google.maps</groupId> | ||
| <artifactId>google-maps-routeoptimization</artifactId> | ||
| <scope>compile</scope> | ||
| </dependency> |
There was a problem hiding this comment.
what is a reasoning to duplicate dependency (via <dependencyManagement> and <dependencies> in this sample project?
please, use one. if you decide to use the selected, remove scope and add version number.
There was a problem hiding this comment.
(NB: I'm not a java packaging expert)
AIUI this isn't a duplicate dependency, the dependencyManagement declaration is equivalent to libraries-bom declared used elsewhere (see http://shortn/_72sIg41fuQ on why libraries-bom isn't used here).
There was a problem hiding this comment.
Resolving since I believe I'm not deviating from precedent modulo the differences/rationale described in the linked document.
There was a problem hiding this comment.
The linked document is outdated (2022). It also does not reference google-maps-routeoptimization-bom. As such it cannot be used as a justification.
Unless you can clearly explain why you need both, please remove this dependency or the BOM dependency above. If you decide to remove BOM, please update this dependency by removing scope (defining compile scope is redundant since it is a default scope) and add the version of the dependency that should be used.
routeoptimization/snippets/src/test/java/com/example/OptimizeToursTest.java
Show resolved
Hide resolved
bshi
force-pushed
the
main
branch
2 times, most recently
from
a72f61f
to
8efe811
Compare
|
Thanks for the review @minherz - code updated and responses ready for another look. |
routeoptimization/snippets/src/main/java/com/example/OptimizeTours.java
Outdated
Show resolved
Hide resolved
routeoptimization/snippets/src/main/java/com/example/OptimizeTours.java
Outdated
Show resolved
Hide resolved
| <groupId>com.google.maps</groupId> | ||
| <scope>import</scope> | ||
| <type>pom</type> | ||
| <version>0.1.0</version> |
There was a problem hiding this comment.
please use the latest (0.3.0) version.
| <dependency> | ||
| <groupId>com.google.maps</groupId> | ||
| <artifactId>google-maps-routeoptimization</artifactId> | ||
| <scope>compile</scope> | ||
| </dependency> |
There was a problem hiding this comment.
The linked document is outdated (2022). It also does not reference google-maps-routeoptimization-bom. As such it cannot be used as a justification.
Unless you can clearly explain why you need both, please remove this dependency or the BOM dependency above. If you decide to remove BOM, please update this dependency by removing scope (defining compile scope is redundant since it is a default scope) and add the version of the dependency that should be used.
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
pom.xmlparent set to latestshared-configurationrouteoptimization.googleapis.commvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only