Add an App Identity example.

[tswast]

This moves the first example from https://cloud.google.com/appengine/docs/java/appidentity/ to GitHub.

I also add a simple unit test to at least make sure this code builds &
runs. Since this sample just wraps:

ApiProxy.getCurrentEnvironment()
    .getAttributes()
    .get("com.google.appengine.runtime.default_version_hostname"))

there isn't really much more we can test in this example.

I will move the other examples from that page over in later PRs.

[tswast]

@shun-fan @lesv Please take a look.

[lesv]

Is this necessary?

[lesv]

Tim - is ths for traditional GAE or MVM's?

[tswast]

This is for traditional GAE. I used the ../helloworld directory as a template, so the README is mostly the same.

I think the appengine-web.xml changes are necessary since we don't have the gcloud config for deploying traditional GAE apps with Maven.

[lesv]

You can then define them as var's in the POM, that are substituted when the appengine-web.xml is copied. Then the user can do mvn appengine:deploy -Dproject=myproj-333 -Dversion=32

[johnshunfan]

I also use tags in the appengine-web.xml to define project and version. Is there a reason to prefer defining them at the command line?

[tswast]

https://cloud.google.com/appengine/docs/java/ has folks modifying appengine-web.xml. Should we change the Hello World instructions to point to the command-line options?

Does it makes sense to have different instructions here for the samples beyond hello world? (I do find command-line options useful when I have a development, qa, and production project)

[johnshunfan]

Apparently you can override the version, but not the project id from the command line, if both are present in the appengine-web.xml. Perhaps we can specify both ways of doing it.

[lesv]

Yes please.

On Tue, Dec 8, 2015 at 4:56 PM, Shun Fan [email protected] wrote:

Apparently you can override the version, but not the project id from the
command line, if both are present in the appengine-web.xml. Perhaps we can
specify both.

—
Reply to this email directly or view it on GitHub
#43 (comment)
.

• • *Les Vogel
• • *Cloud Developer Relations
• • *[email protected]
• • *+1-4 <%2B1-650-338-7103>08-676-7023

[tswast]

I added instructions for how to provide the application ID and version number via the command line. They differed slightly from what @lesv describes in #43 (comment) but I was able to deploy using these parameters. They match what parameters I see when I run:

mvn help:describe -Dcmd=appengine:update -Ddetail

[lesv]

Other than the comments to be on MVM's (email from PM) it's looking good.

[tswast]

@lesv Makes sense. I've updated the sample to use Managed VMs.

[lesv]

If you don't provide a version gcloud will automatically create one for you.

[lesv]

I don't think you need -Dversion, and I'm not sure how it gets used here. I don't see it being used, and / or passed to gcloud-mvn-plugin in anyway.

On the other hand, everything else looks good, I liked learning about truth. We should have a discussion about surefire vs junit vs. others someday.

[tswast]

@lesv I removed the references to -Dversion. It shows up as a parameter when I run mvn help:describe -Dcmd=gcloud:deploy -Ddetail but it does seem to be ignored when I provide one. Since it's not needed, I'll just remove it.

Truth is really great! It's been pushed by the Google Java core libraries team more and more, and I agree with them that it increases the readability of tests and makes it harder to make mistakes on the order of arguments.

[lesv]

LGTM