Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing samples for classification and rename object detection sa… #1604

Merged
merged 4 commits into from
Oct 21, 2019
Merged

Add missing samples for classification and rename object detection sa… #1604

merged 4 commits into from
Oct 21, 2019

Conversation

nnegrey
Copy link
Contributor

@nnegrey nnegrey commented Oct 7, 2019

…mple to add clarification

@nnegrey nnegrey requested a review from a team October 7, 2019 20:53
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 7, 2019
@nnegrey nnegrey assigned lesv and unassigned dzlier-gcp Oct 8, 2019
@nnegrey
Copy link
Contributor Author

nnegrey commented Oct 8, 2019

Looking into why these tests are failing.
Might be because there is only 1 model to deploy and both are trying to deploy it at the same time.

@shuesc1
Copy link

shuesc1 commented Oct 8, 2019

Reminder to ping me when merging these branch samples to master to update official documentation.

lesv
lesv reviewed Oct 9, 2019
View reviewed changes
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be changes to a README for this?

@nnegrey
Copy link
Contributor Author

nnegrey commented Oct 9, 2019

I'm not sure, since we don't have main methods anymore, do we still expect them to be in a README?

@GoogleCloudPlatform GoogleCloudPlatform deleted a comment Oct 21, 2019
@GoogleCloudPlatform GoogleCloudPlatform deleted a comment Oct 21, 2019
@GoogleCloudPlatform GoogleCloudPlatform deleted a comment Oct 21, 2019
@GoogleCloudPlatform GoogleCloudPlatform deleted a comment Oct 21, 2019
@GoogleCloudPlatform GoogleCloudPlatform deleted a comment Oct 21, 2019
@nnegrey nnegrey merged commit 82790c1 into master Oct 21, 2019
@nnegrey
Copy link
Contributor Author

nnegrey commented Oct 21, 2019

Samples published.
Deleting branch.

@nnegrey nnegrey deleted the automl-vision-classification branch October 21, 2019 21:25
@GoogleCloudPlatform GoogleCloudPlatform deleted a comment Oct 22, 2019
@GoogleCloudPlatform GoogleCloudPlatform deleted a comment Oct 22, 2019
@GoogleCloudPlatform GoogleCloudPlatform deleted a comment Oct 22, 2019
@GoogleCloudPlatform GoogleCloudPlatform deleted a comment Oct 22, 2019
@GoogleCloudPlatform GoogleCloudPlatform locked as resolved and limited conversation to collaborators Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lesv lesv lesv approved these changes

Assignees

@lesv lesv

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nnegrey @shuesc1 @lesv @googlebot @dzlier-gcp