Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing build issues caused by dependency update. #1055

Merged
merged 2 commits into from
Mar 26, 2018

Conversation

dzlier-gcp
Copy link
Member

Related to this PR. Also testing to see if changing java-docs-samples-testing@java-docs-samples-testing.iam.gserviceaccount.com's account permissions from BigTable Viewer to Bigtable User fixes the failure with Bigtable Test.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Mar 8, 2018
@dzlier-gcp
Copy link
Member Author

BigTable error is in fact fixed, though now there's a BigQuery error that replaced it. Looking into it.

@dzlier-gcp
Copy link
Member Author

I'm having trouble finding a root cause for this, as the error message isn't very helpful and there isn't much documentation about it that I can find. It seems like the root cause may be buried in the stack trace, but I can't reproduce the error locally.

@lesv
Copy link
Contributor

lesv commented Mar 8, 2018

@tswast PTAL

@lesv
Copy link
Contributor

lesv commented Mar 8, 2018

[ERROR] Tests run: 5, Failures: 0, Errors: 1, Skipped: 1, Time elapsed: 8.771 s <<< FAILURE! - in com.example.bigquery.QuerySampleIT
[ERROR] testPermanentTableQuery(com.example.bigquery.QuerySampleIT)  Time elapsed: 2.743 s  <<< ERROR!
com.google.cloud.bigquery.BigQueryException: java.lang.IllegalArgumentException: key completedInputs
	at com.example.bigquery.QuerySampleIT.testPermanentTableQuery(QuerySampleIT.java:111)
Caused by: java.lang.IllegalArgumentException: key completedInputs
	at com.example.bigquery.QuerySampleIT.testPermanentTableQuery(QuerySampleIT.java:111)
Caused by: java.lang.IllegalArgumentException: key completedInputs, field private com.google.api.services.bigquery.model.JobStatistics com.google.api.services.bigquery.model.Job.statistics
	at com.example.bigquery.QuerySampleIT.testPermanentTableQuery(QuerySampleIT.java:111)
Caused by: java.lang.IllegalArgumentException: key completedInputs, field private com.google.api.services.bigquery.model.JobStatistics2 com.google.api.services.bigquery.model.JobStatistics.query
	at com.example.bigquery.QuerySampleIT.testPermanentTableQuery(QuerySampleIT.java:111)
Caused by: java.lang.IllegalArgumentException: key completedInputs, field private java.util.List com.google.api.services.bigquery.model.JobStatistics2.timeline
	at com.example.bigquery.QuerySampleIT.testPermanentTableQuery(QuerySampleIT.java:111)
Caused by: java.lang.IllegalArgumentException: key completedInputs, field private java.util.List com.google.api.services.bigquery.model.JobStatistics2.timeline
	at com.example.bigquery.QuerySampleIT.testPermanentTableQuery(QuerySampleIT.java:111)
Caused by: java.lang.IllegalArgumentException: key completedInputs, field private java.lang.Integer com.google.api.services.bigquery.model.QueryTimelineSample.completedInputs
	at com.example.bigquery.QuerySampleIT.testPermanentTableQuery(QuerySampleIT.java:111)
Caused by: java.lang.IllegalArgumentException: number field formatted as a JSON string must use the @JsonString annotation
	at com.example.bigquery.QuerySampleIT.testPermanentTableQuery(QuerySampleIT.java:111)

[ERROR] Errors: 
[ERROR]   QuerySampleIT.testPermanentTableQuery:111 ? BigQuery java.lang.IllegalArgument...
[ERROR] Tests run: 11, Failures: 0, Errors: 1, Skipped: 1
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-failsafe-plugin:2.20.1:verify (default) on project bigquery-google-cloud-samples: There are test failures.

@lesv
Copy link
Contributor

lesv commented Mar 8, 2018

@dzlier-gcp it is probably similar. It's sounding like some new IAM features were released recently. I don't see anything in the release notes however.

@tswast
Copy link
Contributor

tswast commented Mar 8, 2018

@pongad did we just discover a bug in the BQ library?

Caused by: java.lang.IllegalArgumentException: number field formatted as a JSON string must use the @JsonString annotation
	at com.example.bigquery.QuerySampleIT.testPermanentTableQuery(QuerySampleIT.java:111)

looks like an error in the library (couldn't parse the job response) as opposed to an error in the sample.

@dzlier-gcp
Copy link
Member Author

dzlier-gcp commented Mar 8, 2018

I had a hunch that might be it, but I wanted a second opinion on it. I can file a bug (pending confirmation).

@pongad
Copy link

pongad commented Mar 8, 2018

@tswast It might very well be. Could you file a bug in google-cloud-java and assign me? A small main method to reproduce this would also be awesome.

@tswast
Copy link
Contributor

tswast commented Mar 9, 2018

Filed googleapis/google-cloud-java#3015

@kurtisvg
Copy link
Contributor

kurtisvg commented Mar 9, 2018

@dzlier-gcp Do you want to just roll back the bigquery update so that we can pull the rest of the updates?

@pongad
Copy link

pongad commented Mar 12, 2018

Another option. You could explicitly declare this dependency in this repo to override. Then after our update makes its way to Maven, you could remove it.

Up to you of course.

@dzlier-gcp
Copy link
Member Author

Taking care of this this afternoon.

@dzlier-gcp
Copy link
Member Author

Bigtable errors are gone, but the container registry tests still fail after being pushed almost a month ago, and I'm not having any luck resolving those.

@dzlier-gcp dzlier-gcp force-pushed the master branch 2 times, most recently from 0376862 to 8b955c8 Compare March 16, 2018 17:31
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Mar 16, 2018
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Mar 20, 2018
@lesv
Copy link
Contributor

lesv commented Mar 20, 2018

@dzlier-gcp you might as well merge then. Use admin

@dzlier-gcp dzlier-gcp force-pushed the master branch 2 times, most recently from 44cb20b to 51ae203 Compare March 26, 2018 16:35
@dzlier-gcp dzlier-gcp merged commit 8a48f92 into GoogleCloudPlatform:master Mar 26, 2018
minherz pushed a commit that referenced this pull request Nov 9, 2022
* Auto-update dependencies.

* Fix build errors caused by dependency updates.
minherz pushed a commit that referenced this pull request Nov 10, 2022
* Auto-update dependencies.

* Fix build errors caused by dependency updates.
minherz pushed a commit that referenced this pull request Nov 10, 2022
* Auto-update dependencies.

* Fix build errors caused by dependency updates.
Shabirmean pushed a commit that referenced this pull request Nov 17, 2022
…1055)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-core](https://github.com/googleapis/java-core) | `2.8.6` -> `2.8.7` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.7/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.7/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.7/compatibility-slim/2.8.6)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.7/confidence-slim/2.8.6)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-core</summary>

### [`v2.8.7`](https://github.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#&#8203;287-httpsgithubcomgoogleapisjava-corecomparev286v287-2022-08-03)

[Compare Source](https://github.com/googleapis/java-core/compare/v2.8.6...v2.8.7)

##### Dependencies

-   update dependency com.google.auth:google-auth-library-bom to v1.9.0 ([#&#8203;894](https://github.com/googleapis/java-core/issues/894)) ([82aaa16](https://github.com/googleapis/java-core/commit/82aaa16cd9813984a0c92d944eb1ad956759a8e5))
-   update dependency io.grpc:grpc-bom to v1.48.1 ([#&#8203;891](https://github.com/googleapis/java-core/issues/891)) ([0b0f9b8](https://github.com/googleapis/java-core/commit/0b0f9b89757b801e8334c764644d7b66032d36d1))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-translate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNDEuMCIsInVwZGF0ZWRJblZlciI6IjMyLjE0MS4wIn0=-->
Shabirmean pushed a commit that referenced this pull request Nov 18, 2022
…1055)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-core](https://github.com/googleapis/java-core) | `2.8.6` -> `2.8.7` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.7/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.7/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.7/compatibility-slim/2.8.6)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.7/confidence-slim/2.8.6)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-core</summary>

### [`v2.8.7`](https://github.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#&#8203;287-httpsgithubcomgoogleapisjava-corecomparev286v287-2022-08-03)

[Compare Source](https://github.com/googleapis/java-core/compare/v2.8.6...v2.8.7)

##### Dependencies

-   update dependency com.google.auth:google-auth-library-bom to v1.9.0 ([#&#8203;894](https://github.com/googleapis/java-core/issues/894)) ([82aaa16](https://github.com/googleapis/java-core/commit/82aaa16cd9813984a0c92d944eb1ad956759a8e5))
-   update dependency io.grpc:grpc-bom to v1.48.1 ([#&#8203;891](https://github.com/googleapis/java-core/issues/891)) ([0b0f9b8](https://github.com/googleapis/java-core/commit/0b0f9b89757b801e8334c764644d7b66032d36d1))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-translate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNDEuMCIsInVwZGF0ZWRJblZlciI6IjMyLjE0MS4wIn0=-->
Shabirmean pushed a commit that referenced this pull request Nov 18, 2022
…1055)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-core](https://github.com/googleapis/java-core) | `2.8.6` -> `2.8.7` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.7/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.7/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.7/compatibility-slim/2.8.6)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.7/confidence-slim/2.8.6)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-core</summary>

### [`v2.8.7`](https://github.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#&#8203;287-httpsgithubcomgoogleapisjava-corecomparev286v287-2022-08-03)

[Compare Source](https://github.com/googleapis/java-core/compare/v2.8.6...v2.8.7)

##### Dependencies

-   update dependency com.google.auth:google-auth-library-bom to v1.9.0 ([#&#8203;894](https://github.com/googleapis/java-core/issues/894)) ([82aaa16](https://github.com/googleapis/java-core/commit/82aaa16cd9813984a0c92d944eb1ad956759a8e5))
-   update dependency io.grpc:grpc-bom to v1.48.1 ([#&#8203;891](https://github.com/googleapis/java-core/issues/891)) ([0b0f9b8](https://github.com/googleapis/java-core/commit/0b0f9b89757b801e8334c764644d7b66032d36d1))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-translate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNDEuMCIsInVwZGF0ZWRJblZlciI6IjMyLjE0MS4wIn0=-->
anguillanneuf pushed a commit that referenced this pull request Dec 5, 2022
…1055)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-core](https://github.com/googleapis/java-core) | `2.8.6` -> `2.8.7` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.7/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.7/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.7/compatibility-slim/2.8.6)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.7/confidence-slim/2.8.6)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-core</summary>

### [`v2.8.7`](https://github.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#&#8203;287-httpsgithubcomgoogleapisjava-corecomparev286v287-2022-08-03)

[Compare Source](https://github.com/googleapis/java-core/compare/v2.8.6...v2.8.7)

##### Dependencies

-   update dependency com.google.auth:google-auth-library-bom to v1.9.0 ([#&#8203;894](https://github.com/googleapis/java-core/issues/894)) ([82aaa16](https://github.com/googleapis/java-core/commit/82aaa16cd9813984a0c92d944eb1ad956759a8e5))
-   update dependency io.grpc:grpc-bom to v1.48.1 ([#&#8203;891](https://github.com/googleapis/java-core/issues/891)) ([0b0f9b8](https://github.com/googleapis/java-core/commit/0b0f9b89757b801e8334c764644d7b66032d36d1))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-translate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNDEuMCIsInVwZGF0ZWRJblZlciI6IjMyLjE0MS4wIn0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants