Skip to content

functions: add "gcf filesystem is not persistent" note #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tbpg merged 3 commits into from
Apr 24, 2020
Merged

functions: add "gcf filesystem is not persistent" note #1359

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af1836a
Add "gcf filesystem is not persistent" note
Apr 18, 2020
d150a5f
Merge branch 'master' into multipart-note
tbpg Apr 24, 2020
4d76f85
functions: gofmt
tbpg Apr 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions functions/http/form.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ func UploadFile(w http.ResponseWriter, r *http.Request) {
// The whole request body is parsed and up to a total of maxMemory bytes of
// its file parts are stored in memory, with the remainder stored on
// disk in temporary files.

// Note that any files saved during a particular invocation may not
// persist after the current invocation completes; persistent files
// should be stored elsewhere, such as in a Cloud Storage bucket.
if err := r.ParseMultipartForm(maxMemory); err != nil {
http.Error(w, "Unable to parse form", http.StatusBadRequest)
log.Printf("Error parsing form: %v", err)
Expand Down