Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace python-jose with google alternative #566

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Jipje
Copy link

@Jipje Jipje commented May 2, 2024

Closes #565

For more context to why python-jose should be replaced, please reference #565

This solution is a modified version of another repository of GoogleCloudPlatform: https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/iap/validate_jwt.py. Although the code was modified as to minimize the amount of changes necessary in this repository.

The certs() method and CERTS global have been replaced by a certs_url parameter in the verify_token method. This did not change behaviour in the tests.

@Jipje Jipje requested a review from a team as a code owner May 2, 2024 12:38
Copy link

snippet-bot bot commented May 2, 2024

Here is the summary of changes.

You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@iennae
Copy link
Contributor

iennae commented May 4, 2024

@Jipje thanks for raising this and investigating a solution

/gcbrun

@iennae iennae added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 4, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 4, 2024
@Jipje
Copy link
Author

Jipje commented May 6, 2024

Cheers @iennae, happy to help out. I am unable to view the details of the kokoro build so am unsure as to why it fails.

Is it anything to do with the adjusted # [START getting_started_auth_certs] comments?

@Jipje
Copy link
Author

Jipje commented Jun 26, 2024

Bumping this @iennae

AUDIENCE = None


# [START getting_started_auth_certs]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jipje can you let me know about why you're removing this block here? Thanks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I answered my own question. I need to fix some stuff in documentation because removing this block will break a page. )

don't create a conflict with pre-existing region tags; ensure that existing region tag doesn't break here
@iennae iennae added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 23, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 23, 2024
@iennae iennae added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 23, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 23, 2024
@iennae iennae added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 26, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace python-jose dependency
3 participants