-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace python-jose with google alternative #566
base: main
Are you sure you want to change the base?
Conversation
Removing the insecure python-jose package
Here is the summary of changes. You are about to delete 1 region tag.
This comment is generated by snippet-bot.
|
@Jipje thanks for raising this and investigating a solution /gcbrun |
Cheers @iennae, happy to help out. I am unable to view the details of the kokoro build so am unsure as to why it fails. Is it anything to do with the adjusted |
Bumping this @iennae |
AUDIENCE = None | ||
|
||
|
||
# [START getting_started_auth_certs] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jipje can you let me know about why you're removing this block here? Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I answered my own question. I need to fix some stuff in documentation because removing this block will break a page. )
don't create a conflict with pre-existing region tags; ensure that existing region tag doesn't break here
Closes #565
For more context to why python-jose should be replaced, please reference #565
This solution is a modified version of another repository of GoogleCloudPlatform: https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/iap/validate_jwt.py. Although the code was modified as to minimize the amount of changes necessary in this repository.
The
certs()
method andCERTS
global have been replaced by acerts_url
parameter in theverify_token
method. This did not change behaviour in the tests.