Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix GCS URLs for sample data in tutorial_langgraph_rag_agent notebook #1397

Merged
merged 4 commits into from
Nov 12, 2024
Merged

fix: Fix GCS URLs for sample data in tutorial_langgraph_rag_agent notebook #1397

merged 4 commits into from
Nov 12, 2024

Conversation

koverholt
Copy link
Member

Description

This PR fixes the sample data path in GCS to one that is publicly accessible.

  • Follow the CONTRIBUTING Guide.
  • You are listed as the author in your notebook or README file.
    • Your account is listed in CODEOWNERS for the file(s).
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
  • Ensure the tests and linter pass (Run nox -s format from the repository root to format).
  • Appropriate docs were updated (if necessary)

@koverholt koverholt requested a review from a team as a code owner November 12, 2024 22:00
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@holtskinner holtskinner merged commit f557cef into main Nov 12, 2024
6 checks passed
@holtskinner holtskinner deleted the tutorial-langgraph-rag-agent-fix-links branch November 12, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holtskinner holtskinner holtskinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koverholt @holtskinner