Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add rag_engine_evaluation.ipynb and @edtsoi430 to rag engine CODEOWNERS #1389

Merged
merged 16 commits into from
Nov 14, 2024
Merged

feat: add rag_engine_evaluation.ipynb and @edtsoi430 to rag engine CODEOWNERS #1389

merged 16 commits into from
Nov 14, 2024
+1,250 −0

Conversation

edtsoi430
Copy link
Contributor

@edtsoi430 edtsoi430 commented Nov 12, 2024 •
edited
Loading

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Follow the CONTRIBUTING Guide.
  • You are listed as the author in your notebook or README file.
    • Your account is listed in CODEOWNERS for the file(s).
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
  • Ensure the tests and linter pass (Run nox -s format from the repository root to format).
  • Appropriate docs were updated (if necessary)

@edtsoi430 edtsoi430 requested a review from a team as a code owner November 12, 2024 00:02
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@holtskinner holtskinner force-pushed the rag-engine-eval branch 2 times, most recently from 657aceb to fd62e12 Compare November 12, 2024 16:53
holtskinner
holtskinner requested changes Nov 12, 2024
View reviewed changes
gemini/rag-engine/rag_engine_evaluation.ipynb Outdated Show resolved Hide resolved
gemini/rag-engine/rag_engine_evaluation.ipynb Outdated Show resolved Hide resolved
gemini/rag-engine/rag_engine_evaluation.ipynb Outdated Show resolved Hide resolved
gemini/rag-engine/rag_engine_evaluation.ipynb Outdated Show resolved Hide resolved
gemini/rag-engine/rag_engine_evaluation.ipynb Outdated Show resolved Hide resolved
gemini/rag-engine/rag_engine_evaluation.ipynb Outdated Show resolved Hide resolved
gemini/rag-engine/rag_engine_evaluation.ipynb Outdated Show resolved Hide resolved
gemini/rag-engine/rag_engine_evaluation.ipynb Outdated Show resolved Hide resolved
gemini/rag-engine/rag_engine_evaluation.ipynb Show resolved Hide resolved
gemini/rag-engine/rag_engine_evaluation.ipynb Outdated Show resolved Hide resolved
Ed Tsoi and others added 13 commits November 14, 2024 09:08
@holtskinner
Add rag engine retrieval quality evaluation notebook
97d9637
@holtskinner
Add rag_engine_evaluation.ipynb to rag-engine repo
e8ee737
@holtskinner
Add rag_engine_evaluation.ipynb to rag-engine repo and add code owner…
a854a4c 
…s for rag-engine
@holtskinner
add beir datasets name to allow.txt
f1eb065
@holtskinner
fix spelling
f0c5630
@holtskinner
Add qrels to allow.txt
3615ea3
@holtskinner
formatting
4fdea64
@edtsoi430 @holtskinner
Update gemini/rag-engine/rag_engine_evaluation.ipynb
3c7f983 
Co-authored-by: Holt Skinner <[email protected]>
@edtsoi430 @holtskinner
Update gemini/rag-engine/rag_engine_evaluation.ipynb
3c8c08e 
Co-authored-by: Holt Skinner <[email protected]>
@holtskinner
Update rag_engine_evaluation.ipynb based on reviewer comments
fcdaa95
@holtskinner
format rag_engine_evaluation.ipynb
0372de7
@holtskinner
fix spelling error within rag_engine_evaluation.ipynb
fc67296
@holtskinner
updated rag_engine_evaluation.ipynb to allow users to use public GCS …
4ba97d3 
…bucket for data ingestion
holtskinner
holtskinner approved these changes Nov 14, 2024
View reviewed changes
gemini/rag-engine/rag_engine_evaluation.ipynb Outdated Show resolved Hide resolved
gemini/rag-engine/rag_engine_evaluation.ipynb Outdated Show resolved Hide resolved
gemini/rag-engine/rag_engine_evaluation.ipynb Outdated Show resolved Hide resolved
@holtskinner holtskinner merged commit 001f18c into GoogleCloudPlatform:main Nov 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holtskinner holtskinner holtskinner approved these changes

Assignees

@edtsoi430 edtsoi430

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edtsoi430 @holtskinner