Sort by uploaded date when creation date is old #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain build tools like pack set the container creation time to the very distant past, like before Docker even existed. This breaks GCR Cleaner's sorting algorithm for "keep". This commit introduces fallback sorting for when the creation date before March 20, 2013 or when two creation dates are equal. In those situations, GCR Cleaner uses the Uploaded date for sorting. In all other cases, it uses the Creation timestamp. - References: #89 - References: #88
|
Thank you for adding this! We at uber adopting bazel for building docker images in some areas. This will help us to keep our gcr clean and tidy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain build tools like pack set the container creation time to the very distant past, like before Docker even existed. This breaks GCR Cleaner's sorting algorithm for "keep". This commit introduces fallback sorting for when the creation date before March 20, 2013 or when two creation dates are equal. In those situations, GCR Cleaner uses the Uploaded date for sorting. In all other cases, it uses the Creation timestamp.