Do not error if digest cannot be deleted due to dangling parent image #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have the same issue and fix seems valid.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would fix the problem described in #118, except I didn't implement any kind of flag - I'm not a go developer at all and I barely managed to get this to build locally and test it - mostly opening this to kickstart a proper fix and maybe it can help someone else.
I tested it for our use case, and it works as expected, but hopefully someone with more experience can test it properly and make it better and/or put it behind a flag. It will also still mark the digests as deleted even though they weren't - not really ideal, but better than an error for us.