Skip to content
This repository was archived by the owner on Apr 25, 2022. It is now read-only.

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Oct 27, 2014

@silvolu Please take a look.

Notice I added a ## When will a new build occur section to the README since you last reviewed.

@dhermes
Copy link
Contributor Author

dhermes commented Oct 27, 2014

Also, we'll need to update the REAMDE a bit with an integration strategy since both sides kind of depend on each other.

I think it should go as follows:

  1. Get the skeleton in place (this commit).
  2. Add a custom_pip_install.sh file to gcloud-python that doesn't actually depend on the wheels yet.
  3. Make a commit to this repo (i.e. a ``LATEST_COMMIT` file) to kick off a build of the wheelhouse.
  4. After the wheelhouse is built, alter custom_pip_install.sh in gcloud-python to try to use the wheelhouse first and then update (as described in the README here)

Also, for reference this is most of the fix for googleapis/google-cloud-python#290

@silvolu
Copy link
Contributor

silvolu commented Oct 27, 2014

Can you add license headers to the .sh files, as shown in line 3-15 of e.g. merge.sh from gcloud-python?

@dhermes
Copy link
Contributor Author

dhermes commented Oct 27, 2014

Addressed and git push -fed as part of original commit.

build_wheels.sh Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move setting all the env variables for configuration to the Travis UI and just leave a commented out list of variables that need to be set here? That would arguably make it easier to use the script across repos (setting on web interface vs changing local files)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call.

I put them at the top so people would know what to change if they wanted to do the same thing for other projects.

I also see that I stupidly (d'oh) left my hacks in there to make Travis run on my own fork.

@silvolu
Copy link
Contributor

silvolu commented Oct 27, 2014

I forgot to add: your plan in 4 steps SGTM

@dhermes
Copy link
Contributor Author

dhermes commented Oct 27, 2014

OK @silvolu I smashed your changes into a single commit and git push -fed.

I also went through the steps in the README and set up this repository to do the builds.

silvolu added a commit that referenced this pull request Oct 27, 2014
Adding Travis config and shell scripts to build wheels.
@silvolu silvolu merged commit 7638d2e into GoogleCloudPlatform:master Oct 27, 2014
@dhermes dhermes deleted the wheels-project branch October 27, 2014 22:59
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Oct 27, 2014
In addition:
- Removes used of "pip install" in Travis config with our custom
  pip install.
- Introducing tox environment "coveralls" to encourage all Python
  dependencies to be contained in "tox.ini".
- Puts LICENSE header back on update_docs.sh and cleaned up some
  bash long line / syntax with shellchecker.

See GoogleCloudPlatform/gcloud-python-wheels#1 (comment)
step 2 for context.
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Oct 28, 2014
In addition:
- Removes used of "pip install" in Travis config with our custom
  pip install.
- Introducing tox environment "coveralls" to encourage all Python
  dependencies to be contained in "tox.ini".
- Puts LICENSE header back on update_docs.sh and cleaned up some
  bash long line / syntax with shellchecker.

See GoogleCloudPlatform/gcloud-python-wheels#1 (comment)
step 2 for context.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants