-
Notifications
You must be signed in to change notification settings - Fork 2
Adding Travis config and shell scripts to build wheels. #1
Conversation
|
Also, we'll need to update the I think it should go as follows:
Also, for reference this is most of the fix for googleapis/google-cloud-python#290 |
|
Can you add license headers to the .sh files, as shown in line 3-15 of e.g. merge.sh from gcloud-python? |
|
Addressed and |
build_wheels.sh
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we move setting all the env variables for configuration to the Travis UI and just leave a commented out list of variables that need to be set here? That would arguably make it easier to use the script across repos (setting on web interface vs changing local files)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call.
I put them at the top so people would know what to change if they wanted to do the same thing for other projects.
I also see that I stupidly (d'oh) left my hacks in there to make Travis run on my own fork.
|
I forgot to add: your plan in 4 steps SGTM |
|
OK @silvolu I smashed your changes into a single commit and I also went through the steps in the README and set up this repository to do the builds. |
Adding Travis config and shell scripts to build wheels.
In addition: - Removes used of "pip install" in Travis config with our custom pip install. - Introducing tox environment "coveralls" to encourage all Python dependencies to be contained in "tox.ini". - Puts LICENSE header back on update_docs.sh and cleaned up some bash long line / syntax with shellchecker. See GoogleCloudPlatform/gcloud-python-wheels#1 (comment) step 2 for context.
In addition: - Removes used of "pip install" in Travis config with our custom pip install. - Introducing tox environment "coveralls" to encourage all Python dependencies to be contained in "tox.ini". - Puts LICENSE header back on update_docs.sh and cleaned up some bash long line / syntax with shellchecker. See GoogleCloudPlatform/gcloud-python-wheels#1 (comment) step 2 for context.
@silvolu Please take a look.
Notice I added a
## When will a new build occursection to the README since you last reviewed.