Skip to content

refactor!: rename cloudevent to cloud_event #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 10, 2021
Merged

refactor!: rename cloudevent to cloud_event #167

merged 4 commits into from
Nov 10, 2021

Conversation

KaylaNguyen
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes label Nov 9, 2021
@KaylaNguyen KaylaNguyen linked an issue Nov 9, 2021 that may be closed by this pull request
CloudEvent signature decorator should be snake case #166
Closed
grant
grant suggested changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@grant grant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Couple comments.

@KaylaNguyen KaylaNguyen requested a review from grant November 10, 2021 00:01
grant
grant approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@grant grant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, didn't find needed changes.

@KaylaNguyen KaylaNguyen merged commit 99a9df6 into master Nov 10, 2021
@KaylaNguyen KaylaNguyen deleted the cloudevent branch November 10, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewrobertson matthewrobertson Awaiting requested review from matthewrobertson

@anniefu anniefu Awaiting requested review from anniefu

1 more reviewer

@grant grant grant approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CloudEvent signature decorator should be snake case

2 participants

@KaylaNguyen @grant