Skip to content

Update envoy to 06/09/2021#532

Merged
qiwzhang merged 3 commits intoGoogleCloudPlatform:masterfrom
qiwzhang:update-envoy-0609
Jun 10, 2021
Merged

Update envoy to 06/09/2021#532
qiwzhang merged 3 commits intoGoogleCloudPlatform:masterfrom
qiwzhang:update-envoy-0609

Conversation

@qiwzhang
Copy link
Contributor

@qiwzhang qiwzhang commented Jun 10, 2021

Envoy updated to latest protobuf repo. It has changed util::Status to match with abls::Status.

Changed service_control_client_cxx to use the new Status
Changed ESPv2 code to use the new Status.

Also have to fix build breaking changes

  • BUILD files remove @envoy/include with @envoy/
  • #include to prefix with "source/"

@google-cla
Copy link

google-cla bot commented Jun 10, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

Signed-off-by: Wayne Zhang <qiwzhang@google.com>
@qiwzhang qiwzhang force-pushed the update-envoy-0609 branch from 787646e to 9636859 Compare June 10, 2021 04:47
qiwzhang added 2 commits June 9, 2021 22:51
Signed-off-by: Wayne Zhang <qiwzhang@google.com>
Signed-off-by: Wayne Zhang <qiwzhang@google.com>
@nareddyt
Copy link
Contributor

/retest

@google-oss-robot
Copy link
Collaborator

@qiwzhang: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ESPv2-API-regression-test 1dedbdd link /test ESPv2-API-regression-test
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@nareddyt nareddyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the padding issue will be fixed in a follow-up CL?

@TAOXUY
Copy link
Collaborator

TAOXUY commented Jun 10, 2021

I assume the padding issue will be fixed in a follow-up CL?

Yes, the change hasn't be submitted in upstream

@google-oss-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nareddyt, qiwzhang, TAOXUY

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [TAOXUY,nareddyt,qiwzhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiwzhang qiwzhang merged commit a98723a into GoogleCloudPlatform:master Jun 10, 2021
@varungbt
Copy link

@qiwzhang How can I configure this option ? I do not see any changes in the configmanager flags to make it configurable?

@qiwzhang
Copy link
Contributor Author

Not yet, I am working on a new PR to add such flag for you to enable it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants