feat: add Spanner samples for MR CMEK #2772
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the summary of changes. You are about to add 4 region tags.
This comment is generated by snippet-bot.
|
product-auto-label
bot
added
the
samples
Change KmsKeyName to KmsKeyNames
Change KmsKeyNamesAsCryptoKeyName to KmsKeyNamesAsCryptoKeyNames
Change KmsKeyNamesAsCryptoKeyName to be KmsKeyNamesAsCryptoKeyNames
Change KmsKeyNamesAsCryptoKeyName to be KmsKeyNamesAsCryptoKeyNames
Change KmsKeyNamesAsCryptoKeyName to be KmsKeyNamesAsCryptoKeyNames and use database encryption config to print
Use database encryption config to print
amanda-tarafa
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
amanda-tarafa
requested changes
Sep 10, 2024
Member
amanda-tarafa
left a comment
amanda-tarafa
left a comment
There was a problem hiding this comment.
Issues I've commented on appear on several places even though I flag them on a single place, please fix all ocurrences.
This code doesn't build, see the build log for errors.
When you have run the tests locally and they pass, let me know and I can run them on the PR with the backup tests enabled to make certain they run on CI before merging. At the moment these new tests will conflict with the existing backup samples and tests.
spanner/api/Spanner.Samples.Tests/CreateBackupWithMRCMEKAsyncTest.cs
Outdated
Show resolved
Hide resolved
spanner/api/Spanner.Samples.Tests/CreateBackupWithMRCMEKAsyncTest.cs
Outdated
Show resolved
Hide resolved
spanner/api/Spanner.Samples.Tests/CreateDatabaseWithMRCMEKAsyncTest.cs
Outdated
Show resolved
Hide resolved
…Test.cs Change naming from MRCMEK to MrCmek
…ithMrCmekAsyncTest.cs Change naming from MRCMEK to MrCmek
…aseWithMrCmekAsyncTest.cs Change from MRCMEK to MrCmek
…abaseWithMrCmekAsyncTest.cs Change from MRCMEK to MrCmek
Change from MRCMEK to MrCmek
Remove old assert
Change assert
Fix naming
amanda-tarafa
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Change kmsKeyNames to { kmsKeyNames }
Change kmsKeyNames to { kmsKeyNames }
Change kmsKeyNames to { kmsKeyNames }
Change kmsKeyNames to { kmsKeyNames }
Make join explicit, fix format
Make join explicit, fix formatting
Make join explicit, fix formatting
Make join explicit, fix formatting
…c.cs Change copy to async
Shorten names and use MR instance
Fix Assert
…AsyncTest.cs Fix Assert
Missing e in create
Initialize KmsKeyNames
amanda-tarafa
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
amanda-tarafa
requested changes
Oct 24, 2024
| Environment.GetEnvironmentVariable("spanner.test.key.location3") ?? "us-east4", | ||
| Environment.GetEnvironmentVariable("spanner.test.key.ring3") ?? "spanner-test-keyring3", | ||
| Environment.GetEnvironmentVariable("spanner.test.key.name3") ?? "spanner-test-key3"); | ||
| public CryptoKeyName[] KmsKeyNames { get; private set; } |
Member
There was a problem hiding this comment.
Suggested change
| public CryptoKeyName[] KmsKeyNames { get; private set; } | |
| public CryptoKeyName[] KmsKeyNames { get; } = new CryptoKeyName[] { KmsKeyName, KmsKeyName1, KmsKeyName2 }; | |
Use only 1 key
Member
|
Closing in favour of #2832 . These are very similar, changea are mostly renaming, and also in how we use some fixture elements. Sample code is identical. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add samples and tests for create database, create backup, copy backup, and restore backup.