Added lightning package to setup file and updated version for re… #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divrawal
requested review from
MattIrv,
akansha1812,
bernardhan33 and
abhibyreddi
… blacklist/exclude package import style in setup.py
|
@divrawal can you update the PR title/description to describe what you're trying to accomplish with this PR? |
divrawal
changed the title
|
Approving this in light of the follow-up task b/356629540. Divya is adding all the details to that ticket. In short we will let this one pass to unblock the other work. But we should prioritize b/356629540 because similar changes here are risky -- we should rely on |
bernardhan33
approved these changes
Jul 31, 2024
|
@divrawal is this ready to merge? |
Yash9060
pushed a commit
that referenced
this pull request
Aug 7, 2024
* Added lightning subdirectory to setup file and updated version for release * Modified packages to instead exclude the testing packages * Exclude top level package * Added back in package_dir field to setup.py * Added back in package_dir field to setup.py * Attempting import fix * Reverted it to working, whitelist build- Will open a bug to address a blacklist/exclude package import style in setup.py * Typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new release with updated lightning dependency