feat: add health checks to proxy #859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurtisvg
suggested changes
Jul 30, 2021
Fixes failing test on Windows.
enocom
approved these changes
Aug 2, 2021
Member
enocom
left a comment
enocom
left a comment
There was a problem hiding this comment.
A few minor suggestions on docstrings. Otherwise, LGTM.
kurtisvg
approved these changes
Aug 2, 2021
enocom
changed the title
enocom
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Introduce health checks to the Cloud SQL proxy client, allowing for the proactive and automatic mitigation of health-related issues. The health checks consist of startup, liveness, and readiness probing, with requests against the proxy container issued via HTTP.
Checklist
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea.
Relevant issues:
Co-authored-by: Tiffany Xiang [email protected]