-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ag2 (Formerly Autogen) Example - Show how to deploy it on Vertex AI Reasoning Engine #158
base: main
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi team,
I'm currently reviewing this pull request and will post my full review in a few minutes. In the meantime, here's a quick summary to help you and other reviewers get up to speed:
This pull request adds a new example demonstrating how to deploy AG2 (formerly Autogen) on the Vertex AI Reasoning Engine. The main change is the addition of a new README.md
file (lines 1-32) within the genai-on-vertex-ai/agents/reasoning_engine/ag2/
directory. This README provides a comprehensive overview of the example notebook, covering:
- Functionality: Explains the multi-agent collaboration, topic customization, remote deployment, literature review generation, and report persistence features.
- What it Covers: Details the steps involved, including environment setup, configuration, topic definition, deployment, monitoring, and report persistence.
The intent is to provide a clear and practical guide for users wanting to leverage AG2's capabilities with Vertex AI's Reasoning Engine for multi-agent research.
Here's a little poem to brighten your day:
Code flows like a river,
Bugs like rocks, a current's test,
Reviews make it clear.
Let me know if you have any questions.
Best,
Gemini
Gemini encountered an error creating the review. You can try again by commenting |
The README.md file for the AG2 example is well-structured and clearly explains the functionality and steps involved. The addition of a README is a great improvement to the pull request. I have no specific suggestions for improvement at this time. |
@code-review-assist review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request adds a README file for the AG2 example deployed on Vertex AI Reasoning Engine. The README provides a good overview of the notebook's functionality and what it covers. The pull request description adheres to the template and provides context for the changes. Here are a few suggestions for improvement:
Co-authored-by: code-review-assist[bot] <182814678+code-review-assist[bot]@users.noreply.github.com>
Co-authored-by: code-review-assist[bot] <182814678+code-review-assist[bot]@users.noreply.github.com>
Co-authored-by: code-review-assist[bot] <182814678+code-review-assist[bot]@users.noreply.github.com>
View / edit / reply to this conversation on ReviewNB Abhishekbhagwat commented on 2024-12-24T00:14:09Z why not just pin the dependency and install the required version of google-cloud-aiplatform with pip install google-cloud-aiplatform==1.73.0 to simplify this. |
View / edit / reply to this conversation on ReviewNB Abhishekbhagwat commented on 2024-12-24T00:14:09Z Can we move the auth section up one cell up and do the imports after auth ? |
|
||
- **Report Persistence:** Provides the option to save the generated literature review to a file for offline review, editing, and collaboration. | ||
|
||
## What This Notebook Covers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure why we need to have this README for just one notebook. Ideally if we want to have more notebooks for AG2, this README would be good. If we want to keep this README, I would recommend making it more generic and explain more on what is AG2, the benefits of running AG2 on Vertex Reasoning Engine.
We can then have a section called notebooks and then provide a link to the notebook and a short 1-2 lines on what that notebook does.
Pull-Request Template
Thank you for your contribution! Please provide a brief description of your changes and ensure you've completed the checklist below.
Description
What does this PR do? Why is it necessary?
Shows how to deploy Ag2 (Formerly Autogen) on Vertex AI Reasoning Engine.
Fixes # (if applicable)
Checklist
nox -s format
to format the code.aaie_notebook_template.ipynb
if submitting a new jupyter notbook.