Conversation
enocom
changed the title
enocom
changed the title
enocom
reviewed
Mar 19, 2026
Member
enocom
left a comment
enocom
left a comment
There was a problem hiding this comment.
Could we rewire pgxv4 to call through to pgxv5?
Collaborator
Author
Let me convert this into a draft in the meantime while I work on just making a generic driver instead (#770). |
nancynh
force-pushed
the
fix-dos
branch
6 times, most recently
from
1a9aca3 to
d8d9fbc
Compare
Collaborator
Author
Talked offline, decided to do the rewiring first and will do the generic driver later. |
enocom
approved these changes
Mar 24, 2026
Member
enocom
left a comment
enocom
left a comment
There was a problem hiding this comment.
Two small documentation changes are warranted. Otherwise, LGTM. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is currently a security flaw in one of pgxv4's dependencies pgproto3 (see GHSA-jqcq-xjh3-6g23). The maintainer of the repo does not plan on fixing it that version since it has reached EOL (see jackc/pgx#2507 (comment), there's also another comment further below clarifying that "only security updates will be accepted from now on up until the project is EOL").
So, we should go ahead and drop support for it since it already reached EOL on July 1, 2025.
Related to #770