Add additional parentheses for EqualNullSafe filter generation #1265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1166 added parentheses when joining multiple filters together. There were already surrounding parentheses for
And
Or
andNot
filters. This updatesEqualNullSafe
to also surround the two separateOR
clauses.At a minimum I feel this improves the readability of the generated filters. Unsure whether, as in the other PR, there is the risk of query correctness when multiple filters are combined together?