-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce early socket read timeout setting. #866
Enforce early socket read timeout setting. #866
Conversation
Set socket read timeout (`fs.gs.http.read-timeout`) as early as possible on new sockets returned from the custom `SSLSocketFactory`. This guarantees the timeout is enforced during TLS handshakes when using Conscrypt as the security provider. See also google/conscrypt#864 . (cherry picked from commit 61f8629) (cherry picked from commit 667836b)
/gcbrun |
Hello @Deependra-Patel and @medb . The backport to branch-2.1.x is somewhat different due to the presence of Apache HTTP Client support. |
Codecov Report
@@ Coverage Diff @@
## branch-2.1.x #866 +/- ##
==================================================
- Coverage 81.79% 80.71% -1.09%
- Complexity 1979 2163 +184
==================================================
Files 128 150 +22
Lines 8607 9819 +1212
Branches 1005 1133 +128
==================================================
+ Hits 7040 7925 +885
- Misses 1145 1418 +273
- Partials 422 476 +54
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
/gcbrun |
I'm not sure what's going on with codecov/patch. It seems to be reporting missing coverage on lines that are unchanged in this pull request. When I try to click through to the Codecov site, I get this error:
|
@medb , thank you for the review. I have merged this. |
Set socket read timeout (
fs.gs.http.read-timeout
) as early as possibleon new sockets returned from the custom
SSLSocketFactory
. Thisguarantees the timeout is enforced during TLS handshakes when using
Conscrypt as the security provider.
See also google/conscrypt#864 .
(cherry picked from commit 61f8629)
(cherry picked from commit 667836b)