adding unit test for batch request failure #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
Codecov Report
@@ Coverage Diff @@
## master #851 +/- ##
============================================
- Coverage 80.53% 80.50% -0.04%
+ Complexity 2000 1999 -1
============================================
Files 136 136
Lines 8967 8972 +5
Branches 1031 1031
============================================
+ Hits 7222 7223 +1
- Misses 1329 1334 +5
+ Partials 416 415 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
abmodi
approved these changes
Aug 16, 2022
|
/gcbrun |
singhravidutt
added a commit
that referenced
this pull request
Aug 18, 2022
(cherry picked from commit 782b3e9)
singhravidutt
added a commit
that referenced
this pull request
Aug 18, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a test case to verify that a failure of individual request of BatchRequest also gets retried.