-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<howto-slider> pt. 2 #131
base: master
Are you sure you want to change the base?
<howto-slider> pt. 2 #131
Conversation
Linting adding mouse events
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
1 similar comment
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Oh also I removed the label from the shadow dom because |
@robdodson 👍 anything else has to be done over here |
I think it's nearly done, sorry for the delay, the holidays got in the way. I'm back in the office this week and hopefully can wrap it up. |
@sendilkumarn this PR addresses some changes from #129
Because I wasn't able to push to that PR I had to create a new one.
The main changes I made were to turn ARIA into an implementation detail. So the element exposes
value, min, max
attributes and properties, and those reflect to ARIA but only as a side effect. Anyone consuming the component should never need to work with ARIA directly (the same way you don't have to work with ARIA when you're using<input type="range>
).I also tried to refactor the code so most things are driven off of setting the value property. So setting the
value
property triggers theattributeChangedCallback
which in turn moves thethumb
.Also note that changing the
min
ormax
attributes/properties will set the value equal to itself again. This is useful if you havevalue=50
and you changemin
from 0 to 50. Thethumb
will update and appear at the beginning of the track instead of in the middle.I think this could use some more work but I think we're getting to a good place :)