Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #759 Drop support for Node 12 #763

Merged
merged 6 commits into from
Feb 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:

strategy:
matrix:
node-version: [12.x, 14.x, 16.x]
node-version: [14.x, 16.x, 18.x]

steps:
- uses: actions/checkout@v2
Expand Down
1 change: 1 addition & 0 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
engine-strict=true
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ projects for Android Applications that launch Progressive Web App (PWA) using
[Trusted Web Activity (TWA)](https://developer.chrome.com/docs/android/trusted-web-activity/).

## Requirements
- [Node.js](https://nodejs.org/en/) 12.0 or above
- [Node.js](https://nodejs.org/en/) 14.15.0 or above

## Getting Started
- To get started with building an application using Bubblewrap, check the [Trusted Web Activity
Expand Down
3 changes: 3 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
"private": true,
"version": "0.4.3",
"description": "Generate TWA projects from a Web Manifest",
"engines": {
"node": ">=14.15.0"
},
"scripts": {
"build": "lerna run build",
"lint": "lerna run lint",
Expand Down
1 change: 1 addition & 0 deletions packages/cli/.npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
engine-strict=true
2 changes: 1 addition & 1 deletion packages/cli/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ a Project for an Android application that launches an existing Progressive Web A
[Trusted Web Activity (TWA)](https://developer.chrome.com/docs/android/trusted-web-activity/).

## Requirements
- [Node.js](https://nodejs.org/en/) 12.0 or above
- [Node.js](https://nodejs.org/en/) 14.15.0 or above

## Setting up the Environment

Expand Down
3 changes: 3 additions & 0 deletions packages/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
"name": "@bubblewrap/cli",
"version": "1.19.1",
"description": "CLI tool to Generate TWA projects from a Web Manifest",
"engines": {
"node": ">=14.15.0"
},
"bin": {
"bubblewrap": "bin/bubblewrap.js"
},
Expand Down
4 changes: 2 additions & 2 deletions packages/cli/src/lib/Cli.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ import {fetchUtils} from '@bubblewrap/core';
export class Cli {
async run(args: string[]): Promise<boolean> {
console.log(BUBBLEWRAP_LOGO);
if (major(process.versions.node) < 12) {
if (major(process.versions.node) < 14) {
throw new Error(`Current Node.js version is ${process.versions.node}.` +
' Node.js version 12 or above is required to run bubblewrap.');
' Node.js version 14 or above is required to run Bubblewrap.');
}
const parsedArgs = minimist(args);
if (parsedArgs.fetchEngine &&
Expand Down
1 change: 1 addition & 0 deletions packages/core/.npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
engine-strict=true
2 changes: 1 addition & 1 deletion packages/core/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ application that launches an existing Progressive Web App (PWA) using a
[Trusted Web Activity (TWA)](https://developer.chrome.com/docs/android/trusted-web-activity/).

## Requirements
- [Node.js](https://nodejs.org/en/) 12.0 or above
- [Node.js](https://nodejs.org/en/) 14.15.0 or above

## Setting up the Environment

Expand Down
3 changes: 3 additions & 0 deletions packages/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
"name": "@bubblewrap/core",
"version": "1.19.1",
"description": "Core Library to generate, build and sign TWA projects",
"engines": {
"node": ">=14.15.0"
},
"scripts": {
"build": "tsc",
"clean": "del dist",
Expand Down
1 change: 1 addition & 0 deletions packages/validator/.npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
engine-strict=true
3 changes: 3 additions & 0 deletions packages/validator/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,6 @@ App(PWA) used inside it matchs the [minimum quality criteria][2].

[1]: https://developer.chrome.com/docs/android/trusted-web-activity/
[2]: https://web.dev/using-a-pwa-in-your-android-app/#quality-criteria

## Requirements
- [Node.js](https://nodejs.org/en/) 14.15.0 or above
3 changes: 3 additions & 0 deletions packages/validator/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
"name": "@bubblewrap/validator",
"version": "1.18.1",
"description": "Validate if an app using Trusted Web Activity fulfills the quality criteria",
"engines": {
"node": ">=14.15.0"
},
"scripts": {
"build": "tsc",
"clean": "del dist",
Expand Down