Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md with requirement for OpenJDK 11 #741

Merged
merged 1 commit into from
Dec 28, 2022

Conversation

emoffett
Copy link
Contributor

Update the text for manually setting up the Environment of README.md to avoid the following issue if OpenJDK 8 is used:

$ bubblewrap doctor
,-----. ,--. ,--. ,--.
| |) /_,--.,--| |-.| |-.| |,---.,--. ,--,--.--.,--,--.,---.
| .-. | || | .-. | .-. | | .-. | |.'.| | .--' ,-. | .-. |
| '--' ' '' | -' | -' | \ --| .'. | | \ '-' | '-' '
------' ----' ---' ---'--'----'--' '----' ----| |-' --'

doctor ERROR Unsupported jdk version. Please download "OpenJDK 11(LTS)" at the link below: https://adoptopenjdk.net/releases.html?variant=openjdk11&jvmVariant=hotspot.

Update the text for manually setting up the Environment of README.md to avoid the following issue if OpenJDK 8 is used:

$ bubblewrap doctor
,-----.        ,--.  ,--.  ,--.
|  |) /_,--.,--|  |-.|  |-.|  |,---.,--.   ,--,--.--.,--,--.,---.
|  .-.  |  ||  | .-. | .-. |  | .-. |  |.'.|  |  .--' ,-.  | .-. |
|  '--' '  ''  | `-' | `-' |  \   --|   .'.   |  |  \ '-'  | '-' '
`------' `----' `---' `---'`--'`----'--'   '--`--'   `--`--|  |-'
                                                           `--'    


doctor ERROR Unsupported jdk version. Please download "OpenJDK 11(LTS)" at the link below:
https://adoptopenjdk.net/releases.html?variant=openjdk11&jvmVariant=hotspot.
@google-cla
Copy link

google-cla bot commented Dec 22, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@emoffett
Copy link
Contributor Author

CLA now signed

@PEConn PEConn merged commit e6325d7 into GoogleChromeLabs:main Dec 28, 2022
@andreban andreban added the documentation Improvements or additions to documentation label Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants