Fix tests for Doctor #677
Merged
Fix tests for Doctor #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests in DoctorSpec seemed to be causing the test suite to abort, and broken tests weren't being properly reported. My guess is that many of the tests in DoctorSpec have actually never worked. This PR fixes DoctorSpec and other tests that were broken.
PEConn
approved these changes
Apr 25, 2022
|
FWIW, I find it annoying that the test suite silently fails. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests in DoctorSpec seemed to be causing the test suite to abort,
and broken tests weren't being properly reported. My guess is that
many of the tests in DoctorSpec have actually never worked.
This PR fixes DoctorSpec and other tests that were broken.