Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JDK version to 11.0.9.1+1 #654

Merged
merged 2 commits into from
Mar 24, 2022

Conversation

julwil
Copy link
Contributor

@julwil julwil commented Feb 21, 2022

This should fix #653 . Fix JDK version to the one that is available at https://github.com/AdoptOpenJDK/openjdk11-binaries/releases/download. .

@andreban
Copy link
Member

@julwil Thank you for this. This looks good, but you'll need to sign the CLA for us to merge the PR.

@julwil
Copy link
Contributor Author

julwil commented Feb 21, 2022

@julwil Thank you for this. This looks good, but you'll need to sign the CLA for us to merge the PR.

Done

@SJShip
Copy link

SJShip commented Mar 3, 2022

Hey guys, it seems the bubblewrap\core still requires JDK 8 when choosing the JDK path manually. @julwil , could you, please fix this in the scope of your PR?

if (file.indexOf('JAVA_VERSION="1.8') < 0) { // Checks if the jdk's version is 8 as needed

@julwil
Copy link
Contributor Author

julwil commented Mar 11, 2022

@SJShip I updated the version in the place you mentioned

@SJShip
Copy link

SJShip commented Mar 17, 2022

@andreban, Is there any way to speed up the merging of the PR? It's really important for my CI\CD pipeline which is currently broken because of original issue.

Copy link
Member

@andreban andreban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@andreban andreban merged commit b6e5b8e into GoogleChromeLabs:main Mar 24, 2022
@andreban andreban added the bug Something isn't working label Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JdkInstaller fails downloading JDK
3 participants