Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Precaching updates for v6 #2639

Merged
merged 2 commits into from
Oct 5, 2020
Merged

Precaching updates for v6 #2639

merged 2 commits into from
Oct 5, 2020

Conversation

philipwalton
Copy link
Member

R: @jeffposnick

Fixes #2638, fixes #1857, fixes #2402, fixes #2574

This PR implements the changes proposed in [RFC] v6 Precaching Updates and Changes #2638

jeffposnick
jeffposnick suggested changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@jeffposnick jeffposnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR mentions that it's an "Initial" set of updates. How complete is it? What's missing?

I am a little confused about what ends up invoking _handle() on the PrecacheStrategy, and I am not sure if that's because this isn't yet the full set of changes.

packages/workbox-core/src/_private/cacheMatchIgnoreParams.ts Outdated Show resolved Hide resolved
packages/workbox-core/src/_private/cacheMatchIgnoreParams.ts Show resolved Hide resolved
packages/workbox-core/src/_private/cacheMatchIgnoreParams.ts Show resolved Hide resolved
packages/workbox-core/src/_private/waitUntil.ts Outdated Show resolved Hide resolved
packages/workbox-precaching/src/PrecacheRoute.ts Outdated Show resolved Hide resolved
packages/workbox-core/src/_private/cacheMatchIgnoreParams.ts Outdated Show resolved Hide resolved
packages/workbox-core/src/_private.ts Show resolved Hide resolved
@jeffposnick jeffposnick changed the title Initial precaching updates for v6 Precaching updates for v6 Sep 29, 2020
@jeffposnick
Copy link
Contributor

Sorry, after realizing that there were several large files whose diffs were hidden, I need to re-review this PR.

@jeffposnick jeffposnick self-requested a review September 30, 2020 18:14
jeffposnick
jeffposnick suggested changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@jeffposnick jeffposnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; this mostly looks good now that I have found the entirety of the code changes.

packages/workbox-precaching/src/PrecacheController.ts Outdated Show resolved Hide resolved
packages/workbox-precaching/src/PrecacheController.ts Show resolved Hide resolved
jeffposnick
jeffposnick approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@jeffposnick jeffposnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this!

@jeffposnick jeffposnick merged commit a6751b9 into v6 Oct 5, 2020
@jeffposnick jeffposnick deleted the precaching-v6 branch October 5, 2020 15:17
@snyk-bot snyk-bot mentioned this pull request Dec 22, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Jul 13, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Oct 4, 2021
Open
@donavon donavon mentioned this pull request Nov 29, 2023
Open
This was referenced Dec 20, 2023
Open
Open
This was referenced Feb 3, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffposnick jeffposnick jeffposnick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@philipwalton @jeffposnick