-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow cacheKeyWillBeUsed to influence the request method check #2616
Allow cacheKeyWillBeUsed to influence the request method check #2616
Conversation
… by returning a get request cache key from cacheKeyWillBeUsed.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! As mentioned in #2615, I'm not sure that I want to advertise this as a way to cache arbitrary POST
requests, but it does makes sense to perform the method check on the cacheKeyWillBeUsed
return value.
If folks who know what they're doing use that as a way to cache POST
requests, then so be it...
Fixes #2615
Moves the request method check after the call to
cacheKeyWillBeUsed
so that developers can potentially cachepost
requests asget
requests.