Fix cleanRedirect logic #1678
Merged
Fix cleanRedirect logic #1678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffposnick
commented
Oct 4, 2018
| @@ -17,8 +17,12 @@ | |||
| // Stub missing/broken Headers API methods in `service-worker-mock`. | |||
| // https://fetch.spec.whatwg.org/#headers-class | |||
| class Headers { | |||
| constructor(obj = {}) { | |||
| this.obj = Object.assign({}, obj); | |||
| constructor(init = {}) { | |||
There was a problem hiding this comment.
We've diverged from service-worker-mock over the years, but this change is roughly https://github.com/pinterest/service-workers/blob/c0eda82a98aa46d9a6fb44a32906fa0c2a4f2b22/packages/service-worker-mock/models/Headers.js#L4-L12
philipwalton
approved these changes
Oct 4, 2018
|
PR-Bot Size PluginChanged File Sizes
New FilesNo new files have been added. All File SizesView Table
Workbox Aggregate Size Plugin9.38KB gzip'ed (63% of limit) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @philipwalton
While investigating #1677 I realized that there's a bug in the
Requestconstructor usage inside the code that "cleans up" redirected responses.The code in this PR just takes the corresponding code from
sw-precache's implementation, which should work.I'm filing this PR against
nextbecause I don't think it's an urgent bug to fix, and I'd rather we don't cut any additional v3 releases if we can help it.