Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workbox-webpack-plugin has indirect dependency on vulnerable ejs 2.7.4 package - needs update #2927

Closed
ViPai82 opened this issue Aug 25, 2021 · 1 comment · Fixed by #2962

Comments

@ViPai82
Copy link

ViPai82 commented Aug 25, 2021

Welcome! Please use this template for reporting bugs or requesting features. For questions about using Workbox, the best place to ask is Stack Overflow, tagged with [workbox]: https://stackoverflow.com/questions/ask?tags=workbox

Library Affected:
workbox-webpack-plugin, workbox-build

Issue or Feature Request Description:
workbox-webpack-plugin has indirect dependency on ejs 2.7.4 with Arbitrary Code Injection vulnerability caused by filename which isn't sanitized for display. The issue is fixed in ejs version 3.1.6. (mde/ejs@abaee2b)

Are there plans to upgrade the dependencies to address this?

Indirect dependency chain:
workbox-webpack-plugin
--> workbox-build
--> @surma/rollup-plugin-off-main-thread
--> ejs

The fix should really be to update @surma/rollup-plugin-off-main-thread to use the new ejs version, and then the dependencies, above it, must be updated as well.

@jeffposnick
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants