Update web vitals #168
Merged
Update web vitals #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ha! I had the exact same change lined up! Was just havign trouble reproducing to confirm it worked. However you are a few versions behind on web-vitals. We're on 1.5.2 now not 1.4.2. Suggested changing in #169 |
|
Sure you're not confusing the library version with the extension version? 😁 |
|
Doh! I wondered why it didn't update automatically with dependabot!!! Sorry! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of the new web-vitals version successfully falling back to the correct target selector, and the extension successfully falling back to the correct element reference. For context, the INP interaction here has a pointerdown entry as the canonical
eventEntrywhich has a null target due to a browser bug. With these changes, we're able to correctly attribute the element receiving the interaction.