Skip to content

Fixed TypeError caused by invoking generator function with 'new' keyword #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PaulKinlan merged 3 commits into from
Jan 11, 2018
Merged

Fixed TypeError caused by invoking generator function with 'new' keyword #553

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
943587f
Fixed TypeError caused by invoking generator function with 'new' keyword
Nov 9, 2017
08a135f
Fixed TypeError caused by invoking generator function with 'new' keyword
woltoe Nov 9, 2017
84d3fd0
Merge branch 'bugfix/generators-typerror' of https://github.com/ifeat…
Nov 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions generators/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ <h3>300px Worth of Words</h3>

document.querySelector('#add-many-words').addEventListener('click', function() {
// This will iterate over an infinite sequence of words.
var infiniteIpsumIterator = new loremIpsumGenerator();
var infiniteIpsumIterator = loremIpsumGenerator();
var manyWordsElement = document.querySelector('#many-words');

for (var word of infiniteIpsumIterator) {
Expand Down Expand Up @@ -167,7 +167,7 @@ <h3>300px Worth of Words</h3>
// Create an iterator from the generator if it doesn't already exist.
// The iterator will yield 5 words, and whether the first word is in uppercase
// or not depends on the value of the 'uppercase' parameter.
fiveWordIpsumIterator = new loremIpsumGenerator(5, uppercase);
fiveWordIpsumIterator = loremIpsumGenerator(5, uppercase);
}

// Get the next value from the iterator.
Expand Down