-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add VP9 codec string sample #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
chcunningham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these samples!
media/vp9-codec-string.js
Outdated
| @@ -0,0 +1,25 @@ | |||
| if (MediaSource.isTypeSupported('video/webm; codecs="vp9"')) { | |||
| log('> VP9, Profile 0, level 1 (later fields defaulted)'); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've always thought of the the old string is completely ambiguous for profile/level. I've not been around long enough to say whether it was originally intended to just imply profile 0, but in practice its used (regrettably) for lots of other profiles/levels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chcunningham What should it say then?
log('Some profile/level of VP9');
media/vp9-codec-string.js
Outdated
| } | ||
|
|
||
| if (MediaSource.isTypeSupported('video/webm; codecs="vp09.01.20.08.01"')) { | ||
| log('> VP9, Profile 0, level 1, bit depth 8, 4:2:0 chroma subsampling ' + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Log doesn't match the string. String shows profile 1, level 2. Sorry, I made this typo in the web platform tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: 4:2:0 chroma subsampling is correct, but could apply to eitehr values of 0 or 1. I realize my test documentation is equally ambiguous. You might help clarify that this is value 4:2:0 variety that includes "colocated with luma (0,0)" ... or similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
|
@chcunningham I've addressed your feedback at 9d0d00e. |
|
By the way, I've tried with the Profile 2 is missing. Is that intended? |
|
LGTM. Profile 2 is supported, but your getting "false" because the specified eotf and color primaries are not supported unless chrome is running in "HDR mode". This is still under development, but you can enable HDR mode by running with --enable-hdr. You can see which color primaries/transfer/matrices require HDR mode (implicitly "color management") here: If you're hoping for profile 2 to be more reliably supported you can choose a different eotf and color primaries. |
|
@chcunningham You're right. It works great with |
|
(@ #517 (comment), @chcunningham is the correct reviewer). |
Hello @wolenetz,
This sample describes the upcoming new VP9 codec string and Profile 2 support in Chrome 60.
What do you think?