-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Always use correct prototype for ordinary objects #67
fix: Always use correct prototype for ordinary objects #67
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR but it has been a while since I've seriously worked on this code so I am struggling to understand the change.
I've left some feedback. I'd also appreciate a test. If it's testing behavior that only shows up in old browsers (and so we can't really test it as the tests only run in modern ones) it would be really worth noting that in a comment too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again. I'd like a test for this but if you don't have time I'm happy to merge after you make a few last changes, and I'll write one afterwards.
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
Co-authored-by: Sam Thorogood <[email protected]>
So I feel like, after some reading, is that this is really just adding improved older browser support. I can't find a practical way to test the outcomes in a modern browser (and I've not updated the tests to delete the things we're checking). I have some tweaks I'll make afterwards but I'm happy. |
Addresses part of #14.
This makes it so that Proxies of ordinary objects are always created with
target.[[Prototype]]
as their prototype.