Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Always use correct prototype for ordinary objects #67

Conversation

ExE-Boss
Copy link
Contributor

Addresses part of #14.

This makes it so that Proxies of ordinary objects are always created with target.[[Prototype]] as their prototype.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ExE-Boss
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Contributor

@samthor samthor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR but it has been a while since I've seriously worked on this code so I am struggling to understand the change.

I've left some feedback. I'd also appreciate a test. If it's testing behavior that only shows up in old browsers (and so we can't really test it as the tests only run in modern ones) it would be really worth noting that in a comment too.

src/proxy.js Show resolved Hide resolved
src/proxy.js Outdated Show resolved Hide resolved
src/proxy.js Outdated Show resolved Hide resolved
@ExE-Boss ExE-Boss requested a review from samthor June 22, 2020 10:28
Copy link
Contributor

@samthor samthor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again. I'd like a test for this but if you don't have time I'm happy to merge after you make a few last changes, and I'll write one afterwards.

src/proxy.js Show resolved Hide resolved
src/proxy.js Outdated Show resolved Hide resolved
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

Co-authored-by: Sam Thorogood <[email protected]>
@ExE-Boss ExE-Boss requested a review from samthor June 30, 2020 15:27
@samthor
Copy link
Contributor

samthor commented Jul 1, 2020

So I feel like, after some reading, is that this is really just adding improved older browser support. I can't find a practical way to test the outcomes in a modern browser (and I've not updated the tests to delete the things we're checking).

I have some tweaks I'll make afterwards but I'm happy.

@samthor samthor merged commit 9788823 into GoogleChrome:master Jul 1, 2020
@ExE-Boss ExE-Boss deleted the fix/use-correct-prototype-for-ordinary-objects branch July 1, 2020 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants