Runtime error encountered: Cannot change settings between gathering and auditing

[wardpeet]

I couldn't run lighthouse-cli with -A anymore. I would always get the following error:

Runtime error encountered: Cannot change settings between gathering and auditing
Error: Cannot change settings between gathering and auditing

It seems that lodash isEqual checks the length of our objects which are not the same. The saved artifact removes all undefined values as it uses JSON.stringify. I convert all undefined values to null so it keeps the keys intact.

[patrickhulce]

good catch @wardpeet thanks for raising! this is a major pain.

I propose fixing this in config. Instead of assigning all the flags we see, we essentially pluck only the valid settings keys to stick into settings. I can pick that up. It does mean that older artifacts will still fail but moving forward they should be OK.

[brendankenny]

I propose fixing this in config. Instead of assigning all the flags we see, we essentially pluck only the valid settings keys to stick into settings.

This sounds good 👍

[wardpeet]

Sounds good. Feel free to close :)

[patrickhulce]

cool beans, it's over in #4960