-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
report: convert to ES modules #12702
Conversation
@@ -0,0 +1,16 @@ | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file should be temporary... once viewer is es modules this just goes away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYT about breaking this up a smidge further? it seems like the build process pieces could be in place even without the esm conversion and separate quite cleanly without much effort?
I might be misestimating the level of effort required for that, so quick gut check first :)
CDT CL is fully passing its tests now. Once this PR merges we can land that and the PSI CL. The CDT integration test is presently failing with this PR, which is expected. It will be passing again when the CDT CL lands. Then I'll re-enable it as a required check. |
ref #12689, #12623
report/renderer
andreport/test/renderer
to ES modulespackage.json
{type: 'module'}
to a couple folders, to be removed when root package.json is esmmoved to misc(build): add build step for report #12707report-generator.js
now readsstandalone.js
from disk, which is generated byyarn build-report
. This file is not checked into source control, but will be published.report/renderer/util.js
tolighthouse-core/util-commonjs.js
. Remove when ☂️ Convert to ES modules #12689 is donewindow
. Remove when viewer is converted to ES modules. Same for treemapCDT CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2939422
PSI CL: cl/377963333