chore(deps): upgrade to storybook 7.6.4, preact 10.19.3, esbuild 0.19.9 #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
storybook grabbed a newer version of esbuild (resulting in following error), so let's update that here too |
connorjclark
changed the title
connorjclark
commented
Dec 14, 2023
| const elements = [...document.querySelectorAll('#root, #root *')]; | ||
| // Note: #storybook-root is made by storybook, #storybook-test-root is made by us in preview.jsx | ||
| // #storybook-root > #storybook-test-root > some_element_being_tested | ||
| const elements = [...document.querySelectorAll('#storybook-root, #storybook-root *')]; |
There was a problem hiding this comment.
pretty sure storybook changed the padding/margin of their root element, hence the change in snapshot sizes
connorjclark
commented
Dec 14, 2023
| @@ -6,15 +6,14 @@ | |||
| 'use strict'; | |||
|
|
|||
| const log = require('debug')('lhci:utils:api-client'); | |||
| const URL = require('url').URL; | |||
There was a problem hiding this comment.
esbuild no longer likes this
This was referenced Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for Node 18 (cuz of an issue with Webpack using now-removed crypto option).