fixes #775: Update deps in docker-server to match global deps #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metalix2
commented
Apr 6, 2022
metalix2
commented
Apr 6, 2022
metalix2
commented
Apr 6, 2022
metalix2
commented
Apr 18, 2022
| @@ -1,4 +1,4 @@ | |||
| FROM node:14-buster-slim | |||
| FROM node:14-bullseye-slim | |||
There was a problem hiding this comment.
Upgraded to satisfy `GLIBC_2.29' dependency for sqlite3
There was a problem hiding this comment.
|
Hey @patrickhulce @connorjclark, PR Ready for review - with the end of support for Node 12 ending in less than 2 weeks (30th of April). It would be good to release a fix to resolve #775 🙏 Look forward to your response. |
patrickhulce
approved these changes
Apr 18, 2022
|
Hey @patrickhulce any news on when this could be merge and released? 🙏 |
|
@connorjclark any chance you have bandwidth for release? |
Any follow up on a release? |
This was referenced Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main fix here is to set the same version the docker server dependencies use as the main packages.
I've tested this and it seems to fix the #775 issue.