Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dep): upgrade to puppeteer 19.7.1 #871

Merged
merged 14 commits into from
Feb 18, 2023
Merged

chore(dep): upgrade to puppeteer 19.7.1 #871

merged 14 commits into from
Feb 18, 2023

Conversation

connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented Feb 15, 2023

  • upgrade to puppeteer 19.7.1
  • upgrade to jest 29.4.3, to get support for "exports" field needed for puppeteer to work
  • port 52427 is used by a system service on Mac... so can't use that in tests

There's the usual text rendering deltas visible in the image snapshots, but there are some things that could be considered bugs to fix:

  • project-dashboard-mixed-v-5-v-6-test-js-project-dashboard-render-the-dashboard-should-look-correct-1-snap.png: oddly has a slightly different y-values on the last two points of the first graph. In fact, every graph seems to shift inexplicable on the last bit. I bisected this to puppeteer 19.0.0, which is Chromium range: 109.0.5412.0...110.0.5479.0
  • Dates are now including seconds
  • project-dashboard-mixed-v-5-v-6-test-js-project-dashboard-render-the-dashboard-should-look-correct-1-snap.png: why the extra space in the date string?
  • simple-comparison-test-js-viewer-simple-comparison-render-the-landing-route-should-look-correct-1-snap.png: completely lost the "Base" label

Fingers crossed this makes tests less flaky.

@connorjclark
Copy link
Collaborator Author

I suspect there was no change to the actual graph rendering, at least no within the range we have here... so few pixels in a line that it wouldn't have triggered the snapshot failure threshold, but the fact that the timestamp regressed (due to toLocaleString in Chrome now using a NBSP instead of a space...), was finally enough to fail the test.

Perhaps the underlying data changed since the snapshot was last updated.

@connorjclark connorjclark changed the title chore(dep): upgrade to puppeteer 19.7.0 chore(dep): upgrade to puppeteer 19.7.1 Feb 18, 2023
@connorjclark connorjclark merged commit 60aa39c into main Feb 18, 2023
mduleone added a commit to mduleone/lighthouse-ci-action that referenced this pull request Feb 21, 2023
A recent [dependency upgrade](GoogleChrome/lighthouse-ci#871) merged into GoogleChrome/lighthouse-ci (which prompted minor-version bumps, not a major version bump) is causing lighthouse to fail to connect to the browser.

Hoping that pinning to 0.9.0 will alleviate the failures we're now seeing, and if my team can gain some time we could potentially dedicate to a proper remediation, we'd be happy to try to resolve further if it isn't already addressed by that point.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant