This repository has been archived by the owner on Mar 14, 2024. It is now read-only.
Browser action docs use incorrect property name in sample manifest #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated. Requested changesIf there are any common problems with the content files you created or modified, they will be listed here.
|
|
✔️ Deploy Preview for developer-chrome-com ready! 🔨 Explore the source changes: 456c27f 🔍 Inspect the deploy log: https://app.netlify.com/sites/developer-chrome-com/deploys/60c29df436fe0b000805df40 😎 Browse the preview: https://deploy-preview-871--developer-chrome-com.netlify.app |
dotproto
changed the title
dotproto
changed the title
rdcronin
approved these changes
Jun 10, 2021
rdcronin
approved these changes
Jun 10, 2021
dotproto
changed the title
|
Words are hard. Thanks, @rdcronin. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first code sample in the browser action API docs indicates that the manifest key for a browser action is "action". This PR fixes that reference to say "browser_action".
This PR also contains a minor clarification on page action.