Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Beta and Dev channel detection #297

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Add Beta and Dev channel detection #297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 26 additions & 7 deletions src/chrome-finder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ export function darwinFast(): string|undefined {
process.env.CHROME_PATH,
process.env.LIGHTHOUSE_CHROMIUM_PATH,
'/Applications/Google Chrome Canary.app/Contents/MacOS/Google Chrome Canary',
'/Applications/Google Chrome Dev.app/Contents/MacOS/Google Chrome Dev',
'/Applications/Google Chrome Beta.app/Contents/MacOS/Google Chrome Beta',
'/Applications/Google Chrome.app/Contents/MacOS/Google Chrome',
];

Expand All @@ -37,7 +39,12 @@ export function darwinFast(): string|undefined {
}

export function darwin() {
const suffixes = ['/Contents/MacOS/Google Chrome Canary', '/Contents/MacOS/Google Chrome'];
const suffixes = [
'/Contents/MacOS/Google Chrome Canary',
'/Contents/MacOS/Google Chrome Dev',
'/Contents/MacOS/Google Chrome Beta',
'/Contents/MacOS/Google Chrome',
];

const LSREGISTER = '/System/Library/Frameworks/CoreServices.framework' +
'/Versions/A/Frameworks/LaunchServices.framework' +
Expand All @@ -52,7 +59,7 @@ export function darwin() {

execSync(
`${LSREGISTER} -dump` +
' | grep -i \'google chrome\\( canary\\)\\?\\.app\'' +
' | grep -i \'google chrome\\( canary\\| dev\\| beta\\)\\?\\.app\'' +
' | awk \'{$1=""; print $0}\'')
.toString()
.split(newLineRegex)
Expand All @@ -71,10 +78,16 @@ export function darwin() {
const home = escapeRegExp(process.env.HOME || homedir());
const priorities: Priorities = [
{regex: new RegExp(`^${home}/Applications/.*Chrome\\.app`), weight: 50},
{regex: new RegExp(`^${home}/Applications/.*Chrome Canary\\.app`), weight: 51},
{regex: new RegExp(`^${home}/Applications/.*Chrome Beta\\.app`), weight: 51},
{regex: new RegExp(`^${home}/Applications/.*Chrome Dev\\.app`), weight: 52},
{regex: new RegExp(`^${home}/Applications/.*Chrome Canary\\.app`), weight: 53},
{regex: /^\/Applications\/.*Chrome.app/, weight: 100},
{regex: /^\/Applications\/.*Chrome Canary.app/, weight: 101},
{regex: /^\/Volumes\/.*Chrome.app/, weight: -2},
{regex: /^\/Applications\/.*Chrome Beta.app/, weight: 101},
{regex: /^\/Applications\/.*Chrome Dev.app/, weight: 102},
{regex: /^\/Applications\/.*Chrome Canary.app/, weight: 103},
{regex: /^\/Volumes\/.*Chrome.app/, weight: -4},
{regex: /^\/Volumes\/.*Chrome Beta.app/, weight: -3},
{regex: /^\/Volumes\/.*Chrome Dev.app/, weight: -2},
{regex: /^\/Volumes\/.*Chrome Canary.app/, weight: -1},
];

Expand Down Expand Up @@ -129,9 +142,11 @@ export function linux() {
installations = installations.concat(findChromeExecutables(folder));
});

// Look for google-chrome(-stable) & chromium(-browser) executables by using the which command
// Look for google-chrome(-stable|-beta|-unstable) & chromium(-browser) executables by using the which command
const executables = [
'google-chrome-stable',
'google-chrome-beta',
'google-chrome-unstable',
'google-chrome',
'chromium-browser',
'chromium',
Expand All @@ -154,7 +169,9 @@ export function linux() {
}

const priorities: Priorities = [
{regex: /chrome-wrapper$/, weight: 51},
{regex: /chrome-wrapper$/, weight: 53},
{regex: /google-chrome-unstable$/, weight: 52},
{regex: /google-chrome-beta$/, weight: 51},
{regex: /google-chrome-stable$/, weight: 50},
{regex: /google-chrome$/, weight: 49},
{regex: /chromium-browser$/, weight: 48},
Expand Down Expand Up @@ -187,6 +204,8 @@ export function win32() {
const installations: Array<string> = [];
const suffixes = [
`${path.sep}Google${path.sep}Chrome SxS${path.sep}Application${path.sep}chrome.exe`,
`${path.sep}Google${path.sep}Chrome Dev${path.sep}Application${path.sep}chrome.exe`,
`${path.sep}Google${path.sep}Chrome Beta${path.sep}Application${path.sep}chrome.exe`,
`${path.sep}Google${path.sep}Chrome${path.sep}Application${path.sep}chrome.exe`
];
const prefixes = [
Expand Down