feat: add waitForInspectableTarget option (fix #145) #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // (optional) Interval in ms, which defines whether and how long an inspectable target should be awaited. | ||
| // `0` means that list of inspectable targets will not be requested and awaited. | ||
| // Default: 0 | ||
| waitForInspectableTarget: number; |
There was a problem hiding this comment.
Wondering if this ought to be the default behavior. about to do a major version anyhow, so we can do a breaking change. Will play with this more later.
also, having a timeout be configurable doesn't make much sense to a user (what is a "correct" value?), should probably just internally wait for some reasonable upper limit (10s?) then fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added new option
waitForInspectableTargetthat allows to wait until target list is available. It should fix #145.