fix: reject promise on failed kill #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
approved these changes
Jun 8, 2018
samccone
reviewed
Jun 9, 2018
| await instance.kill(); | ||
| try { | ||
| await instance.kill(); | ||
| } catch (err) { |
There was a problem hiding this comment.
A log here I think would be a good idea instead of silently eating the error.
There was a problem hiding this comment.
The only reject path is already logging the error, would you prefer it moved up here?
| if (this.chrome) { | ||
| this.chrome.on('close', () => { | ||
| delete this.chrome; | ||
| this.destroyTmp().then(resolve); |
There was a problem hiding this comment.
Hmm can you explain why this line moved? Was there a race in waiting for chrome to close?
There was a problem hiding this comment.
If we didn't close Chrome, the process is still live. Removing the handle to it suggests this instance can resume operating normally now even though something has gone wrong.
It seems like this is the logical place to be deleting our handle to it, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if you've tried to launch canary today you may have noticed some strange behavior...
even if you ctrl-c, it just keeps on chugging. turns out we never resolve/reject the promise on a failed kill and so our sig int handler sits there forever