Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: added a pull request template to the repository #1123

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ci: added a pull request template to the repository #1123

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96f8ee2
added a pull request template
Gmin2 Mar 11, 2024
19e5eae
added the reviewed changes
Gmin2 Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
### Pull Request Checklist
Gmin2 marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need a title here since the PR already has a title.


#### [] Description
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the checkboxes here? I don't think it makes sense in a heading and I'm not sure GitHub would render it.


- [] Brief description of the changes made in this PR.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably doesn't need to be a checklist.


#### [] Issue

- **Fixes** #[issue_number]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the square brackets around the issue number which developers might forget to remove?


#### [] Testing Notes

- Any specific instructions or notes for testing the changes.