This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
handle nodes hosted in a <template> #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valdrinkoshi
force-pushed
the
fix-337
branch
from
276c871 to
2db3a2b
Compare
alice
approved these changes
Mar 1, 2017
src/js/Properties.js
Outdated
| @@ -175,7 +175,8 @@ axs.properties.hasDirectTextDescendant = function(element) { | |||
| while (treeWalker.nextNode()) { | |||
| var resultElement = treeWalker.currentNode; | |||
| var parent = resultElement.parentNode; | |||
| var tagName = parent.tagName.toLowerCase(); | |||
| // parent might not be an Element (e.g. DocumentFragment). | |||
| var tagName = (parent.tagName || '').toLowerCase(); | |||
There was a problem hiding this comment.
Would it make sense to just switch to parentElement on the previous line?
valdrinkoshi
changed the title
|
@alice I've realized the issue happens only if a node is hosted in a var frag = document.createDocumentFragment();
frag.appendChild(document.createElement('div'));
document.body.appendChild(frag); // the <div>.parentNode is <body>
var templ = document.createElement('template');
templ.content.appendChild(document.createElement('div'));
document.body.appendChild(templ); // the <div>.parentNode is <template>.content!I've updated the test and the implementation to handle specifically |
addyosmani
approved these changes
Mar 3, 2017
|
LGTM2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #337.
@alice FYI