This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Closes issue #141 - only audit IDs in IDREFs #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -54,7 +54,7 @@ axs.AuditRules.addRule({ | |||
| } | |||
| // If we made it this far then no DOM ancestor has a required scope role. | |||
| // Now we need to check if anything aria-owns this element. | |||
| var owners = axs.utils.getIdReferrers('aria-owns', element); // there can only be ONE explicit owner but that's a different test | |||
| var owners = axs.utils.getAriaIdReferrers(element, 'aria-owns'); // there can only be ONE explicit owner but that's a different test | |||
There was a problem hiding this comment.
I changed the API:
axs.utils.getIdReferrersnow returns both HTML and ARIA IDREFs- The old "just return ARIA IDREFs" function is renamed to
getAriaIdReferrers - I had to reverse the arguments because arg
attributeNameis now optionalopt_attributeName- I'm operating on the practice of always putting optional arguments last. We could leave it the other way and pass itnullif you prefer.
| if (!id) | ||
| return null; | ||
| id = id.replace(/'/g, "\\'"); // make it safe to use in a selector | ||
| var selectorTemplates = ['[contextmenu=\'{id}\']', '[itemref~=\'{id}\']', 'button[form=\'{id}\']', |
There was a problem hiding this comment.
Sorry, got distracted halfway through reviewing this! Could you make these one per line? I realise it'll be a lot of lines (20 or so?), but it's pretty hard to read like this (plus it'll make it easier to add any new ones if we realise something's missing).
| return null; | ||
| id = id.replace(/'/g, "\\'"); // make it safe to use in a selector | ||
| var selectorTemplates = [ | ||
| '[contextmenu=\'{id}\']', |
There was a problem hiding this comment.
Would be great to comment the source of this list so we can periodically check that it's up to date.
There was a problem hiding this comment.
@alice sorry I got sidetracked on other work.
Sorry there is no definitive list I can find for this.
|
@alice I've addressed your feedback and this should hopefully be good to go? |
|
👍 Go ahead and merge 😄 |
ricksbrown
added a commit
that referenced
this pull request
Sep 24, 2015
Closes issue #141 - only audit IDs in IDREFs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the decision in #141
@alice PTAL