This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Fix ARIA tablist and ARIA tab scope #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alice PTAL |
| var fixture = document.getElementById('qunit-fixture'); | ||
| var expected = []; | ||
| for (var i = 0; i < 4; i++) { | ||
| var item = fixture.appendChild(document.createElement('span')); |
There was a problem hiding this comment.
Why does this test use spans where the previous uses a list? Would this test pass if a list was used?
There was a problem hiding this comment.
It was just to save one line - this test doesn't need a container, the spans are added directly to the fixture. It didn't feel right to add a bunch of li elements without a ul or ol.
I can change it to list if you prefer - the test will still work.
There was a problem hiding this comment.
If you can be bothered, I think it would help avoid future confusion, but 👍 either way.
There was a problem hiding this comment.
Ok no problem - will make that change then merge it.
|
👍 modulo test weirdness |
ricksbrown
added a commit
that referenced
this pull request
Jul 31, 2015
Fix ARIA tablist and ARIA tab scope
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #204
The required context role for
tabended up ontablistinstead.This motivates me to get onto #105