This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Use getDistributedNodes to get nodes distributed into shadowRoots #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice
changed the title
|
Great stuff. I'll admit I had to do a crash course on shadow DOM to understand how this works. This is definitely a better approach than I had originally proposed since it correctly ignores "light DOM" nodes that are not part of the "rendered DOM" (remember when there was just "The DOM"?). |
|
Yeah, I had to do the crash course last year (or was it the year before?) when I wrote the original code! Luckily there's a bunch of good content about it on html5rocks.com and of course I can go bug my colleagues who work on it all day if I don't understand something. |
alice
pushed a commit
that referenced
this pull request
Jan 6, 2015
Use getDistributedNodes to get nodes distributed into shadowRoots
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #126
@ricksbrown PTAL
I thought I might be able to submit a PR to your PR, but it turns out you can only send PRs to the repo you forked from. Seems to miss the point of git a bit! Anyway, your original change is in there.