Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for a breaking change in the Rust compiler. #51

Closed
wants to merge 8 commits into from
Closed

Prepare for a breaking change in the Rust compiler. #51

wants to merge 8 commits into from

Conversation

oli-obk
Copy link

@oli-obk oli-obk commented Sep 21, 2023

The soundness fix in rust-lang/rust#115008 will cause axum-starter to break, even though it is not unsound. The missing bound is very hard to abuse, but still a soundness hole in our type system.

It will likely take 12 weeks before a stable compiler with the soundness fix is shipped.

@Goodjooy
Copy link
Owner

Adding a 'static lifetime bound on the trait Prepare might cause break change. I think migrate change to the next branch is better

@Goodjooy Goodjooy changed the base branch from master to next September 23, 2023 14:19
@Goodjooy
Copy link
Owner

Goodjooy commented Feb 6, 2024

hey @oli-obk the rustc error is be fix in the #54

@Goodjooy Goodjooy closed this Feb 6, 2024
@oli-obk oli-obk deleted the breakage_fix branch February 6, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants